search

Chickenbreadlp / VRCFTVarjoModule

Fork of the Varjo Eye Tracking module for VRCFT
6 stars 1 forks source link

Adding new Option UntrackedEyeFollowTracked #3

Closed jensnt closed 2 months ago

jensnt commented 2 months ago

The new option UntrackedEyeFollowTracked will make an untracked eye follow the other one if that is tracked.

Chickenbreadlp commented 2 months ago

It looks pretty good. My only concern is that this PR mingles left and right pupil sizes. While I understand why it was done this way, the problem is that VRCFT internally keeps track of largest and smallest measured pupil size to calculate a normalized pupil diameter size. Since the left and right pupil can naturally have differing pupil sizes, this could cause problems with the normalized pupil size values.

jensnt commented 2 months ago

It looks pretty good. My only concern is that this PR mingles left and right pupil sizes. While I understand why it was done this way, the problem is that VRCFT internally keeps track of largest and smallest measured pupil size to calculate a normalized pupil diameter size. Since the left and right pupil can naturally have differing pupil sizes, this could cause problems with the normalized pupil size values.

OK, Fixed :)