ChicoState / open-source-security-camera

This project is being developed to provide an alternative home security monitoring system with an emphasis on user data rights and privacy.
MIT License
10 stars 5 forks source link

secret key should be secret #32

Open DJ-IRL opened 2 years ago

DJ-IRL commented 2 years ago

in the name of security, we should really put the secret key in a file that is added to our git-ignore we should all ensure we have a copy of the secret key file and understand how it is read in this issue being resolved means that the secret key will no longer be accessible through the github repo. this also means we cannot have the current key present in any past commits, so we will need to change it.

and then from settings.py we should access it via reading in from a file i think. there may be better, even more secure solutions to this.


at best, it is bad practice. at worst, it could put users at risk

it was my mistake initially, it was included in the first django pull request. my bad y'all.


low priority instead of high, despite it being a huge security flaw, due to: