search

ChicoState / open-source-security-camera

This project is being developed to provide an alternative home security monitoring system with an emphasis on user data rights and privacy.
MIT License
10 stars 5 forks source link

Hot Models in Your Area #65

Closed DJ-IRL closed 2 years ago

DJ-IRL commented 2 years ago

Sorry this PR is so massive, but I believe it is up to par.

Removed a lot of unused and unnecessary includes and variables.

Models for Storage, Network, Camera, and CameraViews are now successfully updating from the views page.

Note: see latest commit message for context.

Happy to contextualize any changes I made.

DJ-IRL commented 2 years ago

It's a lot of changes so I added everyone as a reviewer.

Let me know what you think, in general or specifically.

Always down for constructive criticism. Keep in mind this is not production-perfect, but it gets the job done.

DJ-IRL commented 2 years ago

cyclomatic complexity fails, honestly not sure what to do about that as Django views are djanky as it is. views reference forms and models, forms reference models, not sure exactly what's being measured here tbh.

down to talk abt it monday tho.

with this plus emails i think we're looking good for the next demo

DJ-IRL commented 2 years ago

forgot abt camel. jpg is on purpose. migrations were deleted and properly added to git ignore so we would not track them anymore

DJ-IRL commented 2 years ago

if we're demoing monday, my feeling is we should just merge. i feel all the edits are pretty minor and i likely won't have time to implement them before we present.

the ability to edit settings and the test suite are complete.

things like refactoring functions, making smarter dummy data, renaming stuff, all seems secondary to the gained functionality.

melippmann commented 2 years ago

As we are on deadline and the commits seem legit enough for this sprint I am merging the PR without further reviewers' comments/suggestions.