search

ChiefGokhlayeh / textidote-action

GitHub Action to lint, spell- and grammar-check LaTeX documents using TeXtidote.
MIT License
7 stars 1 forks source link

Action doesn't use gokhlayeh/textidote #51

Closed marcosrmartin closed 1 year ago

marcosrmartin commented 1 year ago

Every time that an action is thrown, it runs the Dockerfile to build the image (executing all the commands and installing all the dependencies), instead of using the Docker image, which is already built and ready to use.

It takes 1 and a half minutes, every time you exec the action. image

ChiefGokhlayeh commented 1 year ago

I see how that might be an inconvenience.

This action builds the image from its Dockerfile as described here. If anything, I would have hoped GitHub cached the action internally. Apparently they don't.

Switching this line in action.yml may provide the desired effect, however, this repo also runs some self-tests to ensure the action is functional before it is being pushed to Docker Hub (e.g. here). If there is a way to run the tests before pushing anything to Docker Hub and having the action.yml reference a tested Docker Hub image, I'd gladly accept it as a PR. Ideas also welcome.