ChiefOfGxBxL / WC3MapTranslator

Translate war3map ⇄ json formats for WarCraft III .w3x maps
https://www.npmjs.com/package/wc3maptranslator
MIT License
73 stars 31 forks source link

Fix invalid unicode string length #23

Closed dulingzhi closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 23


Totals Coverage Status
Change from base Build 19: 0.01%
Covered Lines: 668
Relevant Lines: 723

💛 - Coveralls
ChiefOfGxBxL commented 5 years ago

Hi @dulingzhi, thanks for catching this mistake! As a minor update, would you please update the HexBuffer string test (https://github.com/ChiefOfGxBxL/WC3MapTranslator/blob/master/test/HexBufferTest.js#L15) to demonstrate the unicode functionality? Once that's there I'll be happy to approve this! 😃

dulingzhi commented 5 years ago

Hi @ChiefOfGxBxL I added addString with test cases from other human languages.