ChiefOfGxBxL / WC3MapTranslator

Translate war3map ⇄ json formats for WarCraft III .w3x maps
https://www.npmjs.com/package/wc3maptranslator
MIT License
73 stars 31 forks source link

Typescript Support #28

Closed rufreakde closed 4 years ago

rufreakde commented 4 years ago

Readme has to be changed here since I deleted stuff there before...

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 34


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/translators/index.js 0 13 0.0%
lib/translators/StringsTranslator.js 0 16 0.0%
lib/translators/ImportsTranslator.js 0 19 0.0%
lib/HexBuffer.js 3 26 11.54%
lib/W3Buffer.js 0 35 0.0%
lib/translators/CamerasTranslator.js 0 36 0.0%
lib/translators/RegionsTranslator.js 0 45 0.0%
lib/translators/TerrainTranslator.js 0 45 0.0%
lib/translators/SoundsTranslator.js 0 60 0.0%
lib/translators/object/ObjectsTranslator.js 0 68 0.0%
<!-- Total: 3 701 0.43% -->
Files with Coverage Reduction New Missed Lines %
lib/translators/CamerasTranslator.js 3 0.0%
lib/translators/DoodadsTranslator.js 5 0.0%
lib/translators/RegionsTranslator.js 5 0.0%
lib/translators/StringsTranslator.js 5 0.0%
lib/translators/ImportsTranslator.js 6 0.0%
lib/translators/UnitsTranslator.js 6 0.0%
lib/translators/SoundsTranslator.js 7 0.0%
lib/translators/object/ObjectsTranslator.js 13 0.0%
lib/translators/InfoTranslator.js 21 0.0%
lib/translators/TerrainTranslator.js 29 0.0%
<!-- Total: 100 -->
Totals Coverage Status
Change from base Build 29: -87.3%
Covered Lines: 3
Relevant Lines: 801

💛 - Coveralls
ChiefOfGxBxL commented 4 years ago

@rufreakde My review is mostly complete, but I will not be able to fully complete it until Sunday, Dec 15th due to plans over the next few days. Everything is looking good so far! Thanks for these revisions.