Chikorita-Lover / Caffeinated

A vanilla-style Minecraft mod that adds coffee, a new crop with unique uses!
https://modrinth.com/mod/caffeinated
Creative Commons Zero v1.0 Universal
1 stars 3 forks source link

Crashing Server #9

Closed CalendulaX closed 1 week ago

CalendulaX commented 8 months ago

this mod oddly keeps crashing my server which is fabric 1.20.1. The Crash Report is uploaded. Please check the reason and fix it maybe? crash-2023-12-28_16.30.21-server.txt

Chikorita-Lover commented 8 months ago

When does the crash occur? Is it when a specific portion of the world is loaded, or does it just occur randomly?

CalendulaX commented 8 months ago

I believe it’s crashing when unloaded chunks loading.

Chikorita Lover @.***>于2024年1月7日 周日2:56写道:

When does the crash occur? Is it when a specific portion of the world is loaded, or does it just occur randomly?

— Reply to this email directly, view it on GitHub https://github.com/Chikorita-Lover/Caffeinated/issues/9#issuecomment-1879768070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWURB6RULIKZ5PZMYGDMZSDYNGF3TAVCNFSM6AAAAABBFHY5PKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZG43DQMBXGA . You are receiving this because you authored the thread.Message ID: @.***>

inikishev commented 8 months ago

When does the crash occur? Is it when a specific portion of the world is loaded, or does it just occur randomly?

I have the same issue it says

java.lang.IllegalArgumentException: Cannot get property EnumProperty{name=half, clazz=class net.minecraft.block.enums.DoubleBlockHalf, values=[upper, lower]} as it does not exist in Block{minecraft:air}
    at MC//net.minecraft.state.State.get(State.java:98)
    at com.chikoritalover.caffeinated.block.FloweringCoffeeShrubBlock.randomTick(FloweringCoffeeShrubBlock.java:50)
    at MC//net.minecraft.block.AbstractBlock$AbstractBlockState.randomTick(AbstractBlock.java:1117)
    at MC//net.minecraft.server.world.ServerWorld.redirect$hip000$lithium$redirectBlockStateTick(ServerWorld.java:19243)
    at MC//net.minecraft.server.world.ServerWorld.tickChunk(ServerWorld.java:523)
    at MC//net.minecraft.server.world.ServerChunkManager.tickChunks(ServerChunkManager.java:382)
    at MC//net.minecraft.server.world.ServerChunkManager.tick(ServerChunkManager.java:326)
    at MC//net.minecraft.server.world.ServerWorld.tick(ServerWorld.java:333)
    at net.minecraft.server.MinecraftServer.tickWorlds(MinecraftServer.java:897)
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:824)
    at MC//net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:105)
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:671)
    at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
    at java.base@17.0.4.1/java.lang.Thread.run(Thread.java:833)

seems to happen randomly when just exploring the world

https://gist.github.com/stunlocked1/ea6938b3fab254aefc75b880ce0ad3aa

Chikorita-Lover commented 8 months ago

Okay, I think I may know what the issue is. I'll post a hotfix here in a day or two. Thanks for the report!

Chikorita-Lover commented 8 months ago

Could either of you send one of the seeds where this crash occurs? The crash reports provide the position but not the world seed itself.

Neil2250 commented 4 months ago

crash-2024-05-03_00.03.02-server.txt

Also had a crash on SP, can't repeat the conditions, though. Was going to do a new post but it appears similar enough. I believe it's related to your flowering coffee shrub, but i've gone several worlds with jungles before experiencing this problem, so i'm at a loss as to what could be causing it exactly.

I can't send seed/etc as i'm using a heavily edited world generator, but the only thing I could think could be that the top of the block causes a fatal crash if a block update causes the bottom to pop off without the top realising it (i.e., during terrain placement, if you have a mod that features something that replaces certain types of grass, like the immersive weathing mod's grass silt, or loam, or Blooming Nature's Laterlit).

I have very little experience diagnosing this kind of thing, but it could be also related to the storing of data given it happens on exploration, so it may have something to do with chunk "sections" with vertical chunks. https://wiki.vg/Chunk_Format#:~:text=However%2C%20these%20are%20not%20the,(chunk%20sections%20are%20cubic).

Hope these can be leads to follow. I enjoy this mod. Keep it up! xx

emihead commented 1 week ago

can you backport this fix to 1.20.1? i just had this crash