search

ChildMindInstitute / mindlogger-admin-OLD-Vue

Browser-based interface for administering the MindLogger platform
https://admin-prod.mindlogger.org
Other
4 stars 4 forks source link

Missing validation on activity start time, end time and notification time on uploading the CSV schedule #1686

Closed natalia-muzyka closed 2 years ago

natalia-muzyka commented 2 years ago

The CSV is parsed with the next invalid time values:

The expected valid time input should have 4 digits. Activity start time range (should be smaller than end time): 0000-2358 Activity end time range: 0001-2359 Notifications time range: 0000-2359

CSV file with invalid times: https://drive.google.com/file/d/1584oASihlLMzyU4RdE1qDGRsLlgSezoT/view?usp=sharing

Environment: https://admin-staging.mindlogger.org/ v0.17.8 Win 10 / Chrome 102 jeligi9407@zneep.com / 123456 test conditional (1) Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

Verified as fixed: https://www.screencast.com/t/lRqWieB2HgfF

Environment: https://admin-staging.mindlogger.org/ v0.17.11 Win 10 / Chrome 103