ChildMindInstitute / mindlogger-admin-OLD-Vue

Browser-based interface for administering the MindLogger platform
https://admin-prod.mindlogger.org
Other
4 stars 4 forks source link

The *activity name* plug is displayed in the "Invalid CSV File" error pop-up instead of the actual activity name #1720

Closed natalia-muzyka closed 2 years ago

natalia-muzyka commented 2 years ago

Preconditions The user is logged in on the admin panel https://admin-staging.mindlogger.org/ jeligi9407@zneep.com / 123456

Steps to reproduce

  1. Open a site https://admin-staging.mindlogger.org/
  2. Click the "General calendar" button on any applet with at least one user (vbn123)
  3. Click the "Import schedule" button, and click "Yes"
  4. Upload the CSV schedule which contains one event with Repeats="Yes" but not specified "Frequency"
  5. Pay attention to the screen

Actual result: The activity name plug is displayed in the error pop-up instead of the actual activity name after uploading the CSV schedule which contains one event with Repeats="Yes" but not specified "Frequency"

Expected result: The activity name of the failed activity is displayed in the error pop-up after uploading the CSV schedule which contains one event with Repeats="Yes" but not specified "Frequency"

NOTES: REPRODUCIBLE AFTER UPLOADING THE CSV WIH INVALID ACTIVITY NAME

image.png

image.png

Environment: https://admin-staging.mindlogger.org/ v0.17.11 Win 10 / Chrome 103 jeligi9407@zneep.com / 123456 applets: vbn123 , TokenLogger applet (Anita) Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

fixed for repeats:Yes and no frequency. @jj105 the issue is still reproducible after uploading the CSV with the invalid activity name:

image.png

Environment: https://admin-staging.mindlogger.org/ v0.17.16 Win 10 / Chrome 103 jeligi9407@zneep.com / 123456 applets: vbn123 Applet password: Qwe123!!!

MaksimYurys commented 2 years ago

Verified as fixed.

Screenshots: image.png image.png image.png

Environment: Win 10 // Chrome 103 https://admin-staging.mindlogger.org/ v0.17.17