ChildMindInstitute / mindlogger-admin-OLD-Vue

Browser-based interface for administering the MindLogger platform
https://admin-prod.mindlogger.org
Other
4 stars 4 forks source link

Variable values do not match the user's responses #1743

Closed natalia-muzyka closed 1 year ago

natalia-muzyka commented 2 years ago

Preconditions User is logged in on website: test-user1@com.us / qwerty There is the activity with the configured exportable report. The radio, checkbox, slider, text, age, and date variable are added to the markdown field in the report.

Steps to reproduce

  1. Complete the activity on mobile app by selecting any responses on the radio, checkbox, slider, text, age, and date screens.
  2. Download the admin report on the user's DataViz.
  3. Pay attention to the variable values in the report.

Actual result No age value in the report after completing activity on website

Expected result Age value is displayed in the report after completing activity on website

Reproduces for: radio, checkbox, slider, text, age, and date

image.png

Environment: https://admin-staging.mindlogger.org/ https://admin.mindlogger.org/ Win 10 / Chrome 103 staging account: user-stg@ml.com / 123456 config reports v9 / test D Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

@astef021 The issue is still reproducible for: radio, checkbox, slider, text, date

image.png

natalia-muzyka commented 2 years ago

@astef021 date shows the actually selected month - 1

image.png

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 103 user-stg@ml.com / 123456 config reports v9 / test D Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

Verified as fixed:

image.png

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 103 user-stg@ml.com / 123456 config reports v9 / test D Applet password: Qwe123!!!

natalia-muzyka commented 1 year ago

The issue is reproduced in the printed items (radio, checkbox, slider, text) for variable values of radio button, checkbox, slider, age, date):

image.png

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 103 user-stg@ml.com / 123456 config reports v9 / test D https://admin.mindlogger.org/ Win 10 / Chrome 103 my applet 2 / regular activity 2 Applet password: Qwe123!!!

karser commented 1 year ago

The Prompt 6: "your age" response didn't show up in the report. I fixed it. image.png

karser commented 1 year ago

Now the responses in printed items are rendered correctly as well image.png

image.png

karser commented 1 year ago

Also added variables support to the email body with activity prefix.

Configuration: image.png

Received email: image.png

All available variables: image.png

natalia-muzyka commented 1 year ago

@karser verified as fixed in the report: age variable representation is fixed, and all the variable values(radio, checkbox, slider, text, date, age) are rendered in the printed questions (prompts and options) as expected.

image.png

In the email body variable value won't be supported if activity name contains a character other than space or underscore. For item names we have restrictions: it is possible to set an item name by using letters, numbers, and underscores only. For activity names there are no such restrictions and symbols are common in use.

Video: https://www.screencast.com/t/9yVfIBfGR

I don't remember such a requirement for email body (to support variable values), but I think we could create a new ticket for this issue and clarify if we need to fix it now and what's the priority.

cc: @WorldImpex @binarybottle @eleonova-scn

natalia-muzyka commented 1 year ago

The email body should support variables, so ticket is reopened.

karser commented 1 year ago

@natalia-muzyka Should be fixed image

natalia-muzyka commented 1 year ago

Verified as fixed:

image.png

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 103 user-stg@ml.com / 123456 config reports v9 / test D