search

ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

The URL/PC GIF-animation and video(MP4) repeat continuously on the splash screen #2101

Open natalia-muzyka opened 2 years ago

natalia-muzyka commented 2 years ago

Actual result: The URL/PC GIF-animation and video(MP4) repeat continuously on the splash screen Expected result: There should be a replay button after the screen is complete as per the requirements Video: https://www.screencast.com/t/Vav93Zfob

Environment: ML v0.17.71 (staging) iPhone 8 Plus / iOS 13.3 iPhone 6S // iOS 14.4 Samsung S7 // Android 8 Samsung Tab S6 // Android 9 account: kimberly_ml@protonmail.com // 12345678 applet: splash screen test (1) activities: PC mp4 1920x1920 PC 200x200 gif + cumulative URL 200x200 gif Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

@mtg137 fixed for video: https://www.screencast.com/t/WaNDuwEwPa9b

the issues for GIF: 1) the reload button is displayed right after starting the animation 2) reload button isn't vertically aligned 3) animation still repeats continuously video: https://www.screencast.com/t/TPTxuXJYiGt

Environment: ML v0.17.74 (staging) iPhone 8 Plus / iOS 13.3 Samsung S7 // Android 8 account: kimberly_ml@protonmail.com // 12345678 applet: splash screen test (1) activities: PC mp4 1920x1920 PC 200x200 gif + cumulative URL 200x200 gif Applet password: Qwe123!!!

WorldImpex commented 2 years ago

We need to fix 1 & 2. We will rely on the user setting the stop point of a gif. I don't think this is critical for launch

techdev137 commented 2 years ago

I discussed with @WorldImpex, due to technical constraints, I think we can just fix 2) for now

natalia-muzyka commented 2 years ago

@mtg137 Reload button is still not centered vertically on GIF animation. Maybe it would be better to remove the reload button from GIF animation at all if we aren't going to fix the continuous repeating and displaying the button right after opening the screen? image.png

ML v0.17.76 (staging) iPhone 6S // iOS 14.4 Samsung S7 // Android 8 Samsung Tab S6 // Android 9 applet: splash screen test (1) activities: PC 200x200 gif + cumulative URL 200x200 gif Applet password: Qwe123!!!

techdev137 commented 2 years ago

@natalia-muzyka - I think that is expected behavior I discussed with @WorldImpex on last Friday and I think we want to move the button into the nav bar at the bottom for gif player.

natalia-muzyka commented 2 years ago

Still reproduces on GIF-animation: https://www.screencast.com/t/gUWRW389opoz

Environment: ML v0.19.21 staging Samsung Galaxy S20 // Android 11 iPhone XR // iOS 14.3