ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

A/B Trails: Error Delay and Erroneous Line #2642

Closed WorldImpex closed 2 years ago

WorldImpex commented 2 years ago

Steps to recreate

  1. Open A/B Trails applet and start on an item
  2. Draw a line from Start point to Error
  3. See the error and immediately try drawing a new line
  4. See results

Expected: A new line is drawn while showing the error and the user is successful in either connecting to the correct dots or is shown another error. Actual: No lines are drawn after multiple attempts and when error disappears a line is shown the user did not draw.

https://images.zenhubusercontent.com/103405139/108625e3-04e1-4e86-b1e1-7be8c3340dec/pxl_20220601_163141045_ts_2.mp4

WorldImpex commented 2 years ago
  1. There is still a delay when repeatedly starting from a start point and drawing errors or connecting to the right number
  2. the X is missing on the line
WorldImpex commented 2 years ago

When an error is created, the user can still draw which is expected but the lines do not always show while the user is drawing

WorldImpex commented 2 years ago

I am still seeing a small delay sometimes between error message being shown and the ability to draw another line

natalia-muzyka commented 2 years ago

@WorldImpex @mtg137 it was decided to remove the X to reduce the delay? If yes, then the issue is fixed. I'm able to reproduce small delays (when the next line is shown the previous line is still on the screen for a while): https://www.screencast.com/t/jqwnK9EUD

ML v0.21.3 staging Samsung Galaxy Tab S6 SM-T865 // Android 9.0 Apple iPad 9th gen (2021) / iOS 15.5

WorldImpex commented 2 years ago

@mtg137 Can the X be there and the delay is still removed?

techdev137 commented 2 years ago

yes, the red X can be on error line and delay is still removed.

WorldImpex commented 2 years ago

Please add it back @mtg137

natalia-muzyka commented 2 years ago

@mtg137 red X is still missing. Checked with newly created a/b trails applet and activity. Video: https://www.screencast.com/t/p3tR0Zd16h

ML v0.21.9 staging Samsung Galaxy Tab S6 SM-T865 // Android 9.0 Apple iPad 9th gen (2021) / iOS 15.5 owner: ml3_general_acc@protonmail.com / 12345678 test-user6@mail.com / qwerty a/b trails (1), cognitive tasks ml3 Applet password: Qwe123!!!

techdev137 commented 2 years ago

I think my PR for showing red X is not merged yet. https://github.com/ChildMindInstitute/mindlogger-app/pull/2670

I'll discuss with @devbtech

natalia-muzyka commented 2 years ago

Verified as fixed: https://www.screencast.com/t/sBakuya8m

ML v0.21.10 staging iPhone 7 // iOS 13.1.1 Samsung Galaxy S7 // Android 8 Google Pixel 5a // Android 11 Samsung Galaxy Tab S6 SM-T865 // Android 9.0 Apple iPad 9th gen (2021) / iOS 15.5