Closed natalia-muzyka closed 2 years ago
natalia-muzyka
commented
2 years ago @jj105 @WorldImpex may I add about the button image? Probably the expected is to replace the button with the uploaded image> If so, then the uploaded image should be the same min/max height/width as the button with a specified text
WorldImpex
commented
2 years ago Correct @natalia-muzyka
natalia-muzyka
commented
2 years ago @jj105 images look way better now, and could you fix, please the next:
1 - make the images fit the height or width of the image block depending on image orientation (image block as on mockups) to avoid different representations of images with different sizes:
2 - fixation image should fit the screen as the stimulus image does after fixing the 1st issue
3 - buttons text: right and left paddings are missing, and the text is trimmed, so suggest adding a limitation in 5 characters on button text(on the admin side) 4 - buttons are too narrow on tablets now (after changing the font size)
5 - button images should replace the buttons: the uploaded button images should have max height/width and be clickable
6 - when there is one button it fills all the screen width: could you add max-width for a button so it will have a possible max-width
Environment: ML v0.21.7 staging iPhone 7 // iOS 13.1.1 Samsung Galaxy S7 // Android 8 Samsung Galaxy Tab S6 SM-T865 // Android 9.0 Apple iPad 9th gen (2021) / iOS 15.5 jeligi9407@zneep.com 123456 Flanker test / new, one button, buttons text Applet password Qwe123!!!
MaksimYurys
commented
2 years ago @jj105 1. Cropped pictures on buttons go beyond the borders of buttons
Environment: iPhone 8 // 14.7.1 Samsung Galaxy S8 // 8.0.0
Build: 0.21.9
2. Screen can be scrolled
Environment: Samsung Galaxy S8 // 8.0.0
Build: 0.21.9
3.Inappropriate Frame Behavior, Aspect Ratio Change
Environment https://admin-staging.mindlogger.org/
jj105
commented
2 years ago @MaksimYurys could you let me know email/password of your account and name of applet and activities?
MaksimYurys
commented
2 years ago @jj105
acc: qqtest.02@gmail.com
pass(for accaunt and applet): Qqww!123
applet name: "Flanker test"
activity name: Flanker_360
natalia-muzyka
commented
2 years ago 3 - Frame in the crop tool still has an inappropriate ratio change. When you're changing the frame it jumps randomly from one fixed ratio to another (from mobile to tablet). Expected: There should be one ratio defined. Let it be the mobile button ratio. Video: https://www.screencast.com/t/wbM5yFaMouDk
4 - [iOS] The button image is changed to the blue color on fixation screens Video: https://www.screencast.com/t/mxhu2cBYGnQ
Environment: ML v0.21.12 staging iPhone 7 // iOS 13.1.1 Samsung Galaxy S7 // Android 8 jeligi9407@zneep.com 123456 Flanker test / new Applet password Qwe123!!!
MaksimYurys
commented
2 years ago @jj105
"1. Cropped pictures on buttons go beyond the borders of buttons" - fixed
Environment: iPhone 8 // 14.7.1 Samsung Galaxy S8 // 8.0.0
Build: ML v0.21.12 staging
"2. Screen can be scrolled" - fixed
Environment: Samsung Galaxy S8 // 8.0.0
Build: ML v0.21.12 staging
" 3 - Frame in the crop tool still has an inappropriate ratio change. When you're changing the frame it jumps randomly from one fixed ratio to another (from mobile to tablet). Expected: There should be one ratio defined. Let it be the mobile button ratio. Video: https://www.screencast.com/t/wbM5yFaMouDk " - reproduced
Environment: Win 10 // Chrome 102
"4 - [iOS] The button image is changed to the blue color on fixation screens Video: https://www.screencast.com/t/mxhu2cBYGnQ" - not reproduced
Environment : iPhone 8 // iOS 14.7.1 ML 0.21.12 staging jeligi9407@zneep.com 123456 Flanker test / new Applet password Qwe123!!!
natalia-muzyka
commented
2 years ago 3 - Fixed - Frame in the crop tool still has an inappropriate ratio change. When you're changing the frame it jumps randomly from one fixed ratio to another (from mobile to tablet).
4 - Fixed - [iOS] The button image is changed to the blue color on fixation screens
@jj105 could you clean up, please, the last: the cropped button image is not centered in the button (it is left aligned):
Environment : ML 0.21.16 staging jeligi9407@zneep.com 123456 Flanker test / new Applet password Qwe123!!!
natalia-muzyka
commented
2 years ago Verified as fixed:
Environment : ML 0.21.18 staging jeligi9407@zneep.com 123456 Flanker test / new Applet password Qwe123!!!
natalia-muzyka
commented
2 years ago @jj105
On iOS ML v0.21.26 (staging+Native Flanker)
1 - stimulus, fixation images overlap with buttons and do not have min-max width and height 2 - button images are stretched horizontally on iPad and vertically on iPhone 3 - buttons text font size is too big on iPhone and button missing the paddings
Environment : ML 0.21.26 staging iPhone 7 // iOS 13.1.1 Apple iPad 9th gen (2021) / iOS 15.5 flanker_test@mail.com / 123456 Config Flanker v3 Applet password Qwe123!!!
natalia-muzyka
commented
2 years ago @polividskyi after the latest fixes there are left some issues on iOS/iPadOS. If it helps, I added screenshots from the 0.21.18 build as the expected result:
1 - stimulus, fixation image is still too big, especially on iPad and buttons(+buttons text) are too small on iPad
2 - the uploaded original button image (without cropping) doesn't fit the button height/width, is not cropped and centered
3 - when there is one button it is too wide (fits the screen width) and has the too small font on iPad
Environment: ML v0.21.30 staging iPhone 7 // iOS 13.1.1 https://admin-staging.mindlogger.org/ Win 10 / Chrome 103 flanker_test@mail.com / 123456 config flanker v4 / 50% threshold and no fixation, one button Applet password Qwe123!!!
WorldImpex
commented
2 years ago Please check on iPad @MaksimYurys / @natalia-muzyka but it looks good on iPhone 13 Pro
natalia-muzyka
commented
2 years ago Verified as fixed:
Environment: ML v0.21.36 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 Samsung Galaxy Tab S6 SM-T865 // Android 9.0 Apple iPad 9th gen (2021) / iOS 15.5
Issue: 1 - Image fills out all the screen
2 - Text with 4ch+
Suggestion:
1. Images: There should be an area(square) with min/max width and height in which the image fills the full width or height (depends on ratio). This area should be vertically and horizontally aligned and have enough paddings, e.g (green is just a defined area, it could be vertically and horizontally aligned in addition, I just draw over the current implementation). The buttons should have the same min/max width and height (as well as an image block). The same suggestion is for the fixation screen.
2. Buttons Text: Padding should be bigger, font size could be smaller on the Mobile screen and bigger on Tablet screen. Or if we need to have the same font size then there should be added more paddings and a text input limit of 3 characters. The button should have the same min/max width and height. The text should be aligned.
Environment: ML v0.21.1 staging iPhone 7 // iOS 13.1.1 Samsung Galaxy S7 // Android 8 jeligi9407@zneep.com 123456 Flanker test / new Applet password Qwe123!!!