search

ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

Info text on the practice summary is shown according to 75% threshold instead of the threshold that was actually specified in the builder #2713

Closed natalia-muzyka closed 2 years ago

natalia-muzyka commented 2 years ago

Preconditions Mobile app is installed and launched User is logged in There is the configurable flanker activity with a threshold other than default (75%): Config Flanker v3 / Simple & Choice Reaction Time Task Builder

Steps to reproduce

  1. Open the configurable flanker activity
  2. Pass the practice with 50% accuracy
  3. Pay attention to the info text on the practice summary screen
  4. Pass the practice with 75% accuracy
  5. Pay attention to the info text on the practice summary screen
  6. Observe the result

Actual result: Info text on the test summary is shown according to 75% threshold instead of the threshold that was actually specified in the builder: when the specified threshold in 50% is met there is still a proposal to restart on the passed practice summary, although after tapping the OK button user is moved to the test phase.

Expected result: Info text on the test summary is shown according to the threshold that was specified in the builder

Video: https://www.screencast.com/t/XbsvfrKlWQ4

Environment: ML 0.21.26 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 flanker_test@mail.com / 123456 Config Flanker v3 / Simple & Choice Reaction Time Task Builder Applet password: Qwe123!!!

natalia-muzyka commented 2 years ago

@polividskyi the same issue is reproducible on test summary. Info test is displayed according to the practice threshold 75% Video: https://www.screencast.com/t/yhk9imLq Expected result for the test block summary: the test block summary should be independent of the practice threshold. Test block summary #1 and #2 should suggest continuing the test and the last screen should suggest finishing the activity.

natalia-muzyka commented 2 years ago

The issue is fixed on iOS, but still reproducible on Android. Text and button on the practice summary screen depend on the 75% threshold.

Expected on Practice Summary 1 and 2: text and button depend on the threshold that was actually set up in the builder (50%). Expected on Practice Summary 3: text is always "You responded correctly on [X]% of trials. Your average response time was [Y] ms. Press the button below to continue" + "Continue" button

Expected on Test Summary 1 and 2: text is always "You responded correctly on [X]% of trials. Your average response time was [Y] ms. Press the button below to continue" + "Continue" button Expected on Test Summary 3: text is always "You responded correctly on [X]% of trials. Your average response time was [Y] ms. Press the button below to finish" + "Finish" button

Video: https://www.screencast.com/t/j6A4ycPe5j

Environment: ML v0.21.30 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 flanker_test@mail.com / 123456 config flanker v4 Applet password Qwe123!!!

natalia-muzyka commented 2 years ago

Verified as fixed: https://www.screencast.com/t/6M6Iiydr

Environment: ML v0.21.31 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 flanker_test@mail.com / 123456 config flanker v5 Applet password Qwe123!!!