search

ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

The "Hide badge" checkbox works in opposite way to its state #2792

Closed natalia-muzyka closed 1 year ago

natalia-muzyka commented 2 years ago

Steps to reproduce

  1. Open a site and log in https://admin-staging.mindlogger.org/
  2. Create a new applet with at least two activities or edit existing
  3. Create a new flow(add name, description) and save
  4. Log in to mobile app
  5. Proceed to the applet screen
  6. Pay attention to the flow that has unselected "Hide badge" checkbox in the builder

Actual result The "Hide badge" checkbox works in the opposite way to its state:

  1. When on the applet builder side the checkbox is disallowed the badge is hidden on the mobile app.
  2. When on the applet builder side the checkbox is allowed the badge is shown on the flow card on the mobile app.

Expected result The "Hide badge" checkbox works according to its state:

  1. When on the applet builder side the checkbox is disallowed the badge is shown on the mobile app.
  2. When on the applet builder side the checkbox is allowed the badge is hidden on the flow card on the mobile app.

Requirements (report components / Score component): https://www.figma.com/file/VYuZ9vFaPfK6JnXeAXG8wW/Pre-SRC-Features?node-id=2%3A3060

image.png

Requirements: https://www.figma.com/file/VYuZ9vFaPfK6JnXeAXG8wW/Pre-SRC-Features?node-id=38%3A2946 image.png

Environment: ML v0.21.38 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 user-stg@ml.com / 123456 config reports v9 / My Flow 1, My Flow 3 Applet password: Qwe123!!!

MaksimYurys commented 2 years ago

Verified as fixed.

Screenshots: image.png image.png

Environment: https://admin-staging.mindlogger.org/ v0.17.14 Win 10 // Chrome 103 ML v0.21.42 iPhone 8 // iOS 14.7.1 Samsung Galaxy S8 // Android 8 JhoneeMind@gmail.com // Qqww!123 ConfReports 3 // Qqww!123

natalia-muzyka commented 2 years ago

Issue is reproducible again.

image.png

Environment: https://admin-staging.mindlogger.org/ v0.17.16 Win 10 // Chrome 103 ML v0.21.48 iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 usr2-stg@ml.com / 123456 config reports and flows / flow Applet password: Qwe123!!!

iradchenk0 commented 1 year ago

@anq83

image.png

So, all issues on applet-builder are fixed (package version 0.18.51-alpha, till it's approved), but seems like the remaining issue is on mobile app side

anq83 commented 1 year ago

@iradchenk0 have you deployed it onto Stage ?

anq83 commented 1 year ago

I've fixed it for mobile. You can see it working correctly when:

  1. Deploy applet-builder changes
  2. Deploy mobile changes
  3. Change the value in the flow and save it
  4. Refresh the mobile app

If only to refresh mobile app without change checkbox in Admin - then backend will not return the actual value to mobile app. And mobile app will not change it's checkbox state which is wrong.

anq83 commented 1 year ago

That means - after deploy it into prod - real users will still see the bug, until checkbox in admin changes and user refresh the app.

If to change the flag twice in admin - it will help (force backend to return actual value)

anq83 commented 1 year ago

@natalia-muzyka

TatianaBessonova commented 1 year ago

Verified as fixed. Appearance of a flow in the app corresponds to the state of the "Hide badge" checkbox:

  1. When on the applet builder side the checkbox is disallowed the badge is shown on the mobile app.
  2. When on the applet builder side the checkbox is allowed the badge is hidden on the flow card on the mobile app. Environment: https://admin-staging.mindlogger.org/ Applet builder version v0.18.5-alpha iPhone 7 Plus / iOS 14.4 Google Pixel 3 XL / Android 14.png0
TatianaBessonova commented 1 year ago

Verified on vmbile app version 0.21.57

natalia-muzyka commented 1 year ago

Verified as fixed.

Environment: ML v0.21.57 staging iPhone 13 // iOS 15.6 Google Pixel 5a // Android 11