search

ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

Summary screen is shown at the end of the legacy activity with the disallowed "Show summary" checkbox by default #2824

Open natalia-muzyka opened 2 years ago

natalia-muzyka commented 2 years ago

!!! The last fix in the ticket below should have an effect on the legacy activities, but it doesn't: https://github.com/ChildMindInstitute/mindlogger-app/issues/2771

Preconditions Mobile app is installed and launched There is the legacy activity (created before adding the Config reports feature) with the disallowed "Show summary" checkbox on the Configurable report page (disallowed state is the default)

Steps to reproduce

  1. Complete the activity on the mobile app
  2. Pay attention to the last screen before submitting the response

Actual result Summary screen is shown at the end of the legacy activity with the disallowed "Show summary" checkbox by default

Expected result Summary screen is shown at the end of the activity only if the "show summary" checkbox is allowed and there are data to show (score IDs or selected alert options)

image.png

Environment; ML v0.21.48 staging iPhone 7 // iOS 13.1.1 Google Pixel 5a // Android 11 ml_general_acc@protonmail.com 12345678 my applet / my activity

binarybottle commented 1 year ago

Yao: The language of these checkboxes is misleading and needs to be updated.

See Correct Version here: https://www.figma.com/file/VYuZ9vFaPfK6JnXeAXG8wW/Pre-SRC-Features?node-id=2%3A2016

“Make Report available for Export” → “Generate Report” “Show report at the end of the activity” → “Show Score Summaries”