search

ChildMindInstitute / mindlogger-app

MindLogger (React Native) data collection app
Other
15 stars 6 forks source link

Icon Missing From Summary Screen in Report #2858

Closed e-kass closed 1 year ago

e-kass commented 2 years ago

Icon to the left of the flagged subscales are missing in the summary screen generated in the report.

See correct here - Screenshot of Summary Screen that is generated at the end of the applet/activity flow:

MicrosoftTeams-image.png

See incorrect here - Screenshot of Summary Screen that is generated in the beginning of the emailed report:

Screen Shot 2022-09-01 at 4.12.39 PM.png

NOTE The two screenshots refer to different test cases. They are merely to show the icon showing up in the former and missing in the latter.

natalia-muzyka commented 1 year ago

@Tom1204 Video: https://www.screencast.com/t/Xq2d2TAtQr

Design: https://www.figma.com/file/VYuZ9vFaPfK6JnXeAXG8wW/Pre-SRC-Features?node-id=458%3A5374

Environment: https://admin-staging.mindlogger.org/ user-stg@ml.com / 123456 Config report v14 / Test A Applet password: Qwe123!!!

natalia-muzyka commented 1 year ago

@Tom1204 The icon is present but it is too pixelated. Also, it is trimmed on the top (Windows Chrome). Could you check if the appropriate icon is used? Here is the design: https://www.figma.com/file/VYuZ9vFaPfK6JnXeAXG8wW/Pre-SRC-Features?node-id=112%3A2248

image.png

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 106 macOS 10.15 / Chrome 106 / Safari 13.1.2 new_user@ml.com / 123456 user id test / config report Applet password: Qwe123!!!

Tom1204 commented 1 year ago

@Damirkhon, pls look there is problem with css, as I think Screen Shot 2022-10-31 at 4.38.20 PM.png

Damirkhon commented 1 year ago

changed icon to more high-resolution one. please check and merge @Tom1204 @karser

natalia-muzyka commented 1 year ago

@Damirkhon

The resolution is fixed, but there is one more issue. The exclamation icon should be displayed only near the flagged score. It is displayed near every score now. Mobile app behavior is correct. The issue is only on the report side.

image.png

cc: @yzenchanka

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 106 new_user@ml.com / 123456 user id test / config report Applet password: Qwe123!!!

Damirkhon commented 1 year ago

@natalia-muzyka Done @karser please review PR #13

yzenchanka commented 1 year ago

The issue is fixed: the exclamation icon is displayed only near the flagged score Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 107 iPhone 7 Plus // iOS 14.4 userone@ml.com / QAtest123 Test reports(1)/ Activity A Applet password: Asd123!!! image.png

natalia-muzyka commented 1 year ago

Verified as fixed.

Environment: https://admin-staging.mindlogger.org/ Win 10 / Chrome 107 new_user@ml.com / 123456 user id test / config report Applet password: Qwe123!!!