search

ChildMindInstitute / mindlogger-applet-library

Other
1 stars 0 forks source link

The user isn't able to search with more than one keyword #114

Closed natalia-muzyka closed 3 years ago

natalia-muzyka commented 3 years ago

Steps to reproduce

  1. Open the applet library https://library-staging.mindlogger.org/
  2. Enter any valid keyword in the "Search" field (e.g. "nice")
  3. Add another valid keyword (within the same applet, e/g/ "radio") (divide keywords with a space)
  4. Pay attention to the screen
  5. Remove the space and second keyword. Add a comma and second keyword.
  6. Observe the result

Actual result The "No results found" message is shown after entering two valid keywords that are related to one applet.

Expected result The applets that include two keywords are displayed after entering two valid keywords that are related to one applet.

Video: https://www.screencast.com/t/zabxQe3xdB

Environment https://library-staging.mindlogger.org/ Win 10 // Chrome 93.0.4577.63

natalia-muzyka commented 3 years ago

Verified as fixed. The user is able to search with more than one keyword. Keywords should be separated by commas and space. Video: https://www.screencast.com/t/5FEKhcT6Xep

Environment https://library-staging.mindlogger.org/ Win 10 // Chrome 94.0.4606.61 macOS 11.0 // Safari 14.0.1

natalia-muzyka commented 3 years ago

@Sshetty2 @jj105 The search with a few keywords is broken, probably after the latest changes due to the #120 ticket

Current behavior:

1) if user enters the same "nice applet, yahoo2" the "applet," is ignored and search is made only by "nice" and "yahoo2". Search results aren't specified, there are just search results for "nice" + search results for "yahoo2": image.png

2) if user enters "nice applet yahoo2" search is again not specified, there are search results for "nice" + search results for "applet" + search results for "yahoo2": image.png

Expected: The user enters every new keyword after comma and space, or after space: "nice applet, yahoo2" or "nice applet yahoo2" Every new keyword makes a search more specific (every search result contains all the entered keywords). Video(how it worked): https://www.screencast.com/t/5FEKhcT6Xep

natalia-muzyka commented 3 years ago

@jj105

1) Main page search: Search by a few keywords works only on the applet name, applet description, and keywords level, but ignores applet activity and item levels. Video: https://www.screencast.com/t/MCLi6KYLS

2) On the cart page after entering two keywords search is still not specified, there are search results for "nice" + search results for "applet": image.png

Requirements: image.png

natalia-muzyka commented 3 years ago

Verified as fixed: image.png

Environment https://library-staging.mindlogger.org/ Win 10 // Chrome 94.0.4606.81