ChildMindInstitute / mindlogger-applet-library

Other
1 stars 0 forks source link

Add file name and download button to image uploaders #146

Closed WorldImpex closed 2 years ago

WorldImpex commented 2 years ago

Where an editor has added an image, the editor needs a way to see what the file name was and a way to re-download the image This should be implemented for every image upload widget, (splash screen, watermark, header image, canvas image, etc)

image.png

natalia-muzyka commented 2 years ago

@binaryExDev @devbtech I don't see any changes. Was there a deployment issue?

image.png

WorldImpex commented 2 years ago

No changes still

Screen Shot 2022-01-12 at 7.12.15 AM.png

WorldImpex commented 2 years ago

@binaryExDev Yes that is fine

natalia-muzyka commented 2 years ago

@devbtech @WorldImpex

  1. Uploaded from PC image name doesn't match the original name (if this was the purpose). There is the autogenerated name.
  2. There's no way to download the uploaded image

Video: https://www.screencast.com/t/9cxsxufWndZ

natalia-muzyka commented 2 years ago

The feature is not implemented at all for:

New issues: Some of the uploaded images aren't downloaded after clicking on filename#691 Fixed - The name of the downloaded file doesn't match the name displayed on the admin panel(applet builder) #690 Fixed - Uploaded image name is blank and image can't be downloaded after saving the applet #694

natalia-muzyka commented 2 years ago

@binaryExDev Still not implemented for: About page image: https://www.screencast.com/t/wRr6MFQ8ZMB Splash image: https://www.screencast.com/t/35R4Sv0H

natalia-muzyka commented 2 years ago

Fixed for About page image and Splash image: https://www.screencast.com/t/AvH45ywHOc https://www.screencast.com/t/rnPkzJpzsSF

WorldImpex commented 2 years ago

@natalia-muzyka Is this one we can close?

natalia-muzyka commented 2 years ago

@WorldImpex The last one I was waiting for (it's on dev complete) https://app.zenhub.com/workspaces/mindlogger-webapp-5e11094d0c26311588da9626/issues/childmindinstitute/mindlogger-applet-builder/691

WorldImpex commented 2 years ago

Thanks @natalia-muzyka! @binaryExDev stated that it is an issue with other websites that happens randomly so I think we can backlog that bug and close this ticket

natalia-muzyka commented 2 years ago

ok, thank you for clarification @WorldImpex , other than this issue the implemented feature met the requirements.

Verified on: https://admin-staging.mindlogger.org/ Win 10 // Chrome 98.0.4758.82 macOS 10.15 // Chrome 98.0.4758.82 // Safari 13.1.2