search

ChildMindInstitute / mindlogger-web

MindLogger web application (counterpart to mobile apps)
Other
4 stars 3 forks source link

The external link is opened in the same tab where it was clicked #529

Closed natalia-muzyka closed 2 years ago

natalia-muzyka commented 2 years ago

Preconditions User is logged in on web app There is the applet with the external link user3-dev@ml.com / 123456 Activity Flow 4

Steps to reproduce

  1. Open the applet
  2. Click the "About" button
  3. Click the link
  4. Pay attention to the screen

Actual result The external link is opened in the same tab where it was clicked

Expected result The external link is opened in a new tab

Video: https://www.screencast.com/t/OsbyLgIw

Environment: web-dev.mindlogger.org Win 10 / Chrome 103 user3-dev@ml.com / 123456 Activity Flow 4 Applet password Qwe123!!!

WorldImpex commented 2 years ago

@devbtech I think we should open in new tab

natalia-muzyka commented 2 years ago

@devbtech Is fixed for HTML link by adding target='_blank' attribute in the anchor tag : https://www.screencast.com/t/MURXgvb0

Is reproducible for markdown link: https://www.screencast.com/t/pvO8bUdTVf

user-stg@ml.com 123456 new applet 2 / New activity (1)

MaksimYurys commented 2 years ago

Verified as fixed and for markdown link.

Video: https://images.zenhubusercontent.com/303774485/c287968b-8655-4c9a-b8ed-2dae4d5ca53b/45d3598b_8f0f_421f_8d75_e4b71df7ea25.mp4

Environment: web-dev.mindlogger.org Win 10 / Chrome 103 user3-dev@ml.com / 123456 Activity Flow 4 Applet password Qwe123!!!