search

ChileanVirtualObservatory / acalib

Advanced Computing for Astronomy Library
http://acalib.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 13 forks source link

Removing the Container class #11

Closed maray closed 7 years ago

maray commented 7 years ago

The container is meant to read a fits in a generic way, yet I guess this is impossible, because there are too many variations of them. However, what we can do is to provide only the HDU_to_fits() function. This way, the fits reading is responsibility of the user (there are a lot of tutorials!), and we only do the transformation to NDData. What do you think?

cvalenzu commented 7 years ago

We still need a common data structure for some algorithms that uses a collection of images as input (like staking) o to return a collection of tables and images (like indexing).

maray commented 7 years ago

I know... ASYDO also uses the container, but maybe we have to rethink the interface at least.

maray commented 7 years ago

I think we should use the generic IO interface for this. http://docs.astropy.org/en/stable/io/unified.html

cvalenzu commented 7 years ago

That astropy generic interface look good, we could use something like that.

On Mon, Oct 24, 2016 at 4:06 PM, Mauricio Araya notifications@github.com wrote:

I think we should use the generic IO interface for this. http://docs.astropy.org/en/stable/io/unified.html

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ChileanVirtualObservatory/acalib/issues/11#issuecomment-255835071, or mute the thread https://github.com/notifications/unsubscribe-auth/AEdy28_NwSwbK6_vNgnzqjIx1EWNnGPfks5q3QHMgaJpZM4Kd0ny .

maray commented 7 years ago

This issue is closed because Issue #12 will address this.