Indexing Algorithm Name and Documentation

ChileanVirtualObservatory / acalib

Advanced Computing for Astronomy Library

http://acalib.readthedocs.io/en/latest/

GNU General Public License v3.0

7 stars 13 forks source link

Indexing Algorithm Name and Documentation #15

Closed maray closed 7 years ago

maray commented 7 years ago

The name of the class "Indexing" is too general. We should change the name to something more clear, and refer in the documentation to the paper and to the original code. Probably we should discuss the name with @marcelomendoza

cvalenzu commented 7 years ago

CubeIndexer sounds good, but a better idea is to ask @marcelomendoza

maray commented 7 years ago

Can we close this issue @Nesus ?

cvalenzu commented 7 years ago

We still doen't have change the algorithm name

cvalenzu commented 7 years ago

I think the Algorithm will remain as Indexing for now

maray commented 7 years ago

Hey!. From the documentation: https://github.com/ChileanVirtualObservatory/acalib/blob/master/acalib/algorithms/indexing.py#L9

We can name this algorithm RoISE (Region of Interest Seek and Extraction). Do you agree @cvalenzu ?

I reopen this as an issue, because the change will affect @capgadsx and @Legutier at least...