search

ChileanVirtualObservatory / acalib

Advanced Computing for Astronomy Library
http://acalib.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 13 forks source link

UPI Object Oriented Interface + UPI bugfixes #60

Closed maray closed 7 years ago

maray commented 7 years ago

This pull request implements a Data object that extends NDData in the UPI that implements the methods as an object oriented version of the same functions. All across the library, Data is returned instead of NDData/NDDataRef.

A few bugfixes of the UPI and Algorithms can be found. In the comments I will discuss more about this.

maray commented 7 years ago

The following commits I think could be applied to the master

https://github.com/ChileanVirtualObservatory/acalib/pull/60/commits/4f097a06406dc778baf91f40000e38c4a4d8311e

https://github.com/ChileanVirtualObservatory/acalib/pull/60/commits/f7ee121d15d7bb70bdeef5ec22c643b247a97676

maray commented 7 years ago

Also, I've translated the notebook of the course part III to OO https://github.com/ChileanVirtualObservatory/notebooks/blob/master/course/III%20-%20Data%20Analysis%20with%20OO%20.ipynb

maray commented 7 years ago

As there was no comments about this request, and it is so cool... I will just accept it. ;)