search

Chilipp / autodocsumm

Extending your autodoc API docs with a summary
Apache License 2.0
48 stars 14 forks source link

Missing declared dependency on `six` needs resolution #35

Closed sirosen closed 3 years ago

sirosen commented 3 years ago

I understand that it's probably still desirable to support py2 in this project, but as some projects move to py3 only its becoming possible to have a package which doesn't depend on six 😲 !

Anyway, I think autodocsumm should either

A) add six to its dependencies (no version, I think) or B) treat six being absent as "automatic PY3 mode"

I haven't looked at the code yet, but my inclination would be to add

# _compat.py

try:
    import six
except ImportError:
    PY3 = True
else:
    PY3 = six.PY3

and see what else needs wrapping. I can submit a PR if that would be interesting.

Chilipp commented 3 years ago

thanks for bringing this up @sirosen! I think we can remove it entirely as sphinx is nowadays python3 only, too. I can fix this today

sirosen commented 3 years ago

Awesome! I just stumbled over this project today, so now I'm thinking about using it myself. Thanks for helping to make sphinx that much better to work with.