ENH: Enable conversion of non-Python notebooks to downloadable scripts

Chilipp / sphinx-nbexamples

⛔️ Deprecated: Create an examples gallery with sphinx from Jupyter Notebooks

MIT License

15 stars 11 forks source link

ENH: Enable conversion of non-Python notebooks to downloadable scripts #6

Closed effigies closed 5 years ago

effigies commented 5 years ago

This may not be properly guarded; I don't have a lot of Notebooks to test against. Kind of hoping your tests will catch dependency on non-required metadata.

Closes #4.

coveralls commented 5 years ago

Coverage decreased (-0.09%) to 87.5% when pulling c25f317e90b0f92231dc9e45381e3067a3b71214 on effigies:fix/drop_python_file into 3a87e26ab621362e88b6ea9ba44f82f0b77374f7 on Chilipp:master.

coveralls commented 5 years ago

Coverage decreased (-0.09%) to 87.5% when pulling c25f317e90b0f92231dc9e45381e3067a3b71214 on effigies:fix/drop_python_file into 3a87e26ab621362e88b6ea9ba44f82f0b77374f7 on Chilipp:master.

coveralls commented 5 years ago

Coverage decreased (-0.09%) to 87.5% when pulling c25f317e90b0f92231dc9e45381e3067a3b71214 on effigies:fix/drop_python_file into 3a87e26ab621362e88b6ea9ba44f82f0b77374f7 on Chilipp:master.

coveralls commented 5 years ago

Coverage decreased (-0.09%) to 87.5% when pulling c25f317e90b0f92231dc9e45381e3067a3b71214 on effigies:fix/drop_python_file into 3a87e26ab621362e88b6ea9ba44f82f0b77374f7 on Chilipp:master.

Chilipp commented 5 years ago

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

Sorry, I increased the threshold for coverage checks. You can ignore this failure

Chilipp commented 5 years ago

Let me know, when you are done with it and need any review or work from my side. Thank you for the contribution 😃

In any case, I would add a non-Python notebook here and a test for it

effigies commented 5 years ago

Oh, sorry, just read:

In any case, I would add a non-Python notebook here and a test for it.

Sounds good.

effigies commented 5 years ago

Okay, this is ready for review. Docs build locally, if not very prettily:

Chilipp commented 5 years ago

Awesome! Thanks a lot @effigies for your input! 👍 I added the bash_kernel package to be installed on RTD (otherwise building the docs will fail) and I added some tests for your bash example. When the tests pass, I will merge this PR.