Closed ixjlyons closed 5 years ago
Dear @ixjlyons. I'm finally coming back to you. I implemented the changes in the pip-install-fix
branch (see https://github.com/Chilipp/straditize/pull/6/). Could you please check out this branch (git checkout pip-install-fix
) and run your installation commands again?
I'm not sure if you get an email notification when a PR is reviewed, but this and the other two issues I opened look like they're resolved once the corresponding PRs are merged.
I'm not sure if you get an email notification when a PR is reviewed
I got a notification. Thank you :)
Hello, here from the JOSS review openjournals/joss-reviews#1216
Problem description
Following the docs on installation in a new virtual environment, I found that just running
pip install straditize
wasn't enough to get the application running. Since nothing upstream seems to require a PyQt package, it has to be installed separately.PyQt is also not mentioned on the installation page as a dependency because it's more properly a dependency of psyplot-gui, so that make sense.
I think at least it should be mentioned on the page that you need PyQt4 or PyQt5 installed and it won't be installed for you.
I understand some of the frustrating things about Qt and Python -- when Riverbank started building and releasing PyQt5 wheels with Qt bundled on PyPI, I just decided I'd make my application strictly dependent on PyQt5 and make life easier. :) If users don't have a preference on 4 vs. 5, just suggesting
pip install pyqt5
would be helpful.Also, if you haven't seen it before, qtpy may be worth looking at.
Environment information
Arch Linux Python 3.7.2 (system package) pip 18.1
Created a new virtual environment (
python -m venv .venv
), then ranpip install straditize
. Here's what I get when trying to run it: