Chilipp / straditize

⛔️ Python package for digitizing pollen diagrams
https://straditize.readthedocs.io
GNU General Public License v3.0
14 stars 5 forks source link

Pip install fix #6

Closed Chilipp closed 5 years ago

Chilipp commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will increase coverage by 2.06%. The diff coverage is 87.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   86.11%   88.17%   +2.06%     
==========================================
  Files          26       26              
  Lines       11247    11313      +66     
==========================================
+ Hits         9685     9975     +290     
+ Misses       1562     1338     -224
Impacted Files Coverage Δ
straditize/widgets/colnames.py 88.16% <0%> (+22.33%) :arrow_up:
straditize/__main__.py 80% <100%> (-2.8%) :arrow_down:
straditize/colnames.py 91.33% <100%> (+43.38%) :arrow_up:
straditize/widgets/data.py 91.63% <100%> (ø) :arrow_up:
straditize/binary.py 88.03% <100%> (+0.12%) :arrow_up:
straditize/widgets/menu_actions.py 74.45% <50%> (-0.11%) :arrow_down:
straditize/magnifier.py 93.06% <76.47%> (+1.4%) :arrow_up:
straditize/widgets/tutorial/beginner.py 94.09% <87.5%> (+0.03%) :arrow_up:
straditize/straditizer.py 89% <92.59%> (-0.8%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07f1696...0e9f8af. Read the comment docs.

Chilipp commented 5 years ago

This PR is ready to be merged. It addresses https://github.com/Chilipp/straditize/issues/1 and https://github.com/Chilipp/straditize/issues/8. In particular:

It will be merged if @sgrieve and @ixjlyons are okay with the proposed changes (see https://github.com/Chilipp/straditize/issues/1#issuecomment-462475855 and https://github.com/Chilipp/straditize/issues/8#issuecomment-462484135).

Chilipp commented 5 years ago

Thanks a lot for your quick response and your time! The suggested changes have been implemented. I will merge this PR now.