ChillarAnand / stocktrends

A python package to calculate trends in stocks, derivates(Futures & Options) using Renko, PnF, LineBreak etc
GNU General Public License v3.0
233 stars 74 forks source link

Issue with renko charts in 0.1.5 version #16

Closed ChillarAnand closed 3 years ago

ChillarAnand commented 3 years ago

@KemarReid Can you please provide sample data for which you are facing this issue?

I have tested renko with the sample data here and it seems to be working fine.

https://github.com/ChillarAnand/stocktrends/blob/master/tests/HDFCLIFE.csv

KemarReid commented 3 years ago

https://drive.google.com/file/d/1DHkykhElNOQXyDoiI81MsdPdFKKeTyBS/view?usp=sharing

ChillarAnand commented 3 years ago

@KemarReid What is the brick size you are using?

If you use a large brick size, there will be only one row. See below examples.

$ py demo.py

Renko box calcuation based on periodic close
Brick size: 20
                        date  open  high   low  close  uptrend
0  2016-04-01 00:00:00+05:00 -20.0   0.0 -20.0    0.0     True
$ py demo.py

Renko box calcuation based on periodic close
Brick size: 0.05
                        date  open  high   low  close  uptrend
0  2016-04-01 00:00:00+05:00  1.00  1.05  1.00   1.05     True
1  2016-03-02 09:00:00+05:00  1.05  1.10  1.05   1.10     True
2  2016-02-05 08:00:00+05:00  1.10  1.15  1.10   1.15     True
3  2016-12-14 19:00:00+05:00  1.10  1.10  1.05   1.05    False
4  2017-07-17 20:00:00+05:00  1.10  1.15  1.10   1.15     True
5  2017-08-29 01:00:00+05:00  1.15  1.20  1.15   1.20     True
6  2018-01-25 10:00:00+05:00  1.20  1.25  1.20   1.25     True
7  2018-10-08 00:00:00+05:00  1.20  1.20  1.15   1.15    False
8  2019-08-30 10:00:00+05:00  1.15  1.15  1.10   1.10    False
9  2020-01-12 10:00:00+05:00  1.15  1.20  1.15   1.20     True
KemarReid commented 3 years ago

Thank you. I just ran it using that example and it works perfectly

ChillarAnand commented 3 years ago

Glad it helped.

Closing this issue. Feel free to re-open the issue if you need any help.