Open Zero3 opened 3 years ago
Well... If my issues get automatically closed by stalebot like this, I will most likely stop contributing bug reports to this project. I already spent time creating the bug reports, so seeing it wasted by having them closed by a bot because they have not been fixed yet is super demotivating.
When providing an
INamingConventions
implementation that overridesGetEnumValueName(object value)
, it is also applied to the introspection schema, making it incompliant with the GraphQL specification, at least as far as I can tell.The default
DefaultNamingConventions
doesvalue.ToString().ToUpperInvariant()
, which gives correct enum names during introspection, like this field in an entry of__Type
:But making a
CustomNamingConventions
that doesvalue.ToString();
instead, for example, then the introspection results become seemingly incompliant (see http://spec.graphql.org/June2018/#sec-Schema-Introspection)I've tested with various third party tools that use GraphQL introspection, and they return introspection errors when using the
CustomNamingConventions
in my example.HotChocolate version: 10.5.3