search

ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
4.94k stars 722 forks source link

Update NATS library #6809

Open TechnoBerry opened 3 months ago

TechnoBerry commented 3 months ago

Product

Hot Chocolate

Is your feature request related to a problem?

HotChocolate.Subscriptions.Nats based on the library that is no longer maintained: https://github.com/Cysharp/AlterNats

The solution you'd like

It would be good to migrate HotChocolate.Subscriptions.Nats to the official NATS client: https://github.com/nats-io/nats.net.v2

michaelstaib commented 3 months ago

Hey @TechnoBerry do you want to do a PR on this?

glen-84 commented 3 months ago

@oising FYI. 🙂

oising commented 3 months ago

@TechnoBerry I wouldn't update this just yet -- there's still a lot of churn going on with the 2.x NATS client, with breaking changes being introduced even with minor releases. I'd wait until 2.1 at least. They're on 2.1-preview3 at the moment.

While it's true that AlterNats is no longer being maintained (in fact, the NATS v2 client is a direct fork of AlterNats) - it is very stable.

/cc @michaelstaib

TechnoBerry commented 3 months ago

A fair point. I think it really makes sense to wait for version 2.1.