search

ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
4.96k stars 722 forks source link

Fix incorrect cache control maxAge documentations #7056

Closed kiangkuang closed 1 month ago

kiangkuang commented 1 month ago

Fixes incorrect caching XML documentations to align with header cache-control max-age usage and code behaviour of using seconds instead of milliseconds.

Closes #7053

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.11%. Comparing base (ed99eb6) to head (2efabec). Report is 1 commits behind head on main.

:exclamation: Current head 2efabec differs from pull request most recent head 76eb914. Consider uploading reports for the commit 76eb914 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7056 +/- ## ========================================== + Coverage 72.02% 72.11% +0.09% ========================================== Files 2607 2621 +14 Lines 130140 130776 +636 ========================================== + Hits 93728 94312 +584 - Misses 36412 36464 +52 ``` | [Flag](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7056/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7056/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | `72.11% <ø> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tobias-tengler commented 1 month ago

Can you maybe update ICacheControlOptions.DefaultMaxAge as well?

kiangkuang commented 1 month ago

I've updated ICacheControlOptions.DefaultMaxAge, let me know if there's anywhere else I have missed.