search

ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
4.96k stars 722 forks source link

Use CacheControlScope.Public per default #7058

Closed tobias-tengler closed 3 weeks ago

tobias-tengler commented 1 month ago

Fixes #7055

github-actions[bot] commented 1 month ago

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
kiangkuang commented 1 month ago

Would it be more appropriate to allow the default scope be customizable similar to DefaultMaxAge, or should that be deferred to a future enhancement?

tobias-tengler commented 1 month ago

Yes, this can also be done, but it wouldn't address the underlying issue. I'm going to add it later.

github-actions[bot] commented 1 month ago

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Redundant 'object.ToString()' call 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.08%. Comparing base (723733e) to head (d0c9fb1). Report is 3 commits behind head on main.

:exclamation: Current head d0c9fb1 differs from pull request most recent head 9d576ad. Consider uploading reports for the commit 9d576ad to get more accurate results

Files Patch % Lines
...olate/Caching/src/Caching/CacheControlAttribute.cs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7058 +/- ## ========================================== - Coverage 77.27% 72.08% -5.20% ========================================== Files 2632 2621 -11 Lines 131349 130776 -573 ========================================== - Hits 101505 94265 -7240 - Misses 29844 36511 +6667 ``` | [Flag](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7058/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | `72.08% <90.00%> (-5.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.