search

ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
4.96k stars 722 forks source link

Fixed issue with the internal serializer map. #7064

Closed michaelstaib closed 1 month ago

github-actions[bot] commented 1 month ago

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Redundant nullable warning suppression expression 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.58824% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.29%. Comparing base (94d0339) to head (faf8e43).

Files Patch % Lines
...ypes/Relay/Serialization/LegacyNodeIdSerializer.cs 70.00% 9 Missing :warning:
...pes/Relay/Serialization/DefaultNodeIdSerializer.cs 71.42% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7064 +/- ## ========================================== - Coverage 77.30% 77.29% -0.02% ========================================== Files 2623 2609 -14 Lines 131012 130376 -636 ========================================== - Hits 101280 100774 -506 + Misses 29732 29602 -130 ``` | [Flag](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7064/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7064/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | `77.29% <70.58%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

michaelstaib commented 1 month ago

@plhester the tests are actually in there :) two tests that check for legacy behavior and also for testing collisions of buckets in the map.