unity install from git have many compile error

[mjfme]

Describe the bug

To Reproduce uniy 2022.3 , just install from the url https://github.com/Chillu1/ModiBuff.git#upm with package manager

Am I missing any setup configurations or version requirements?

Expected behavior

[Chillu1]

You're right, it seems that the meta files action is missing some new files/directories, something funky is going on there. Can you take a look at it @Tr0sT ?

You can import the library manually by copying over the ModiBuff/ModiBuff directory to something like a plugins directory for now.

I will look into it more in the weekend.

[mjfme]

Thank you for your reply.

You can import the library manually by copying over the ModiBuff/ModiBuff directory to something like a plugins directory for now.

I have try this way already. I put ModiBuff.Core and ModiBuff.Units to my project . Basically I can try to learn to use Modibuff now. But there is a problem with json serialization related functionality, unity not support for .net native System.Text.Json, here are some infomation

[Chillu1]

Yeah sorry, that's on me. The serialization logic should be split into two parts, one generic where it doesn't have an opinion on the the serialization implementation.

And the other that uses System.Text.Json, I still haven't encapsulated that logic in a compiler directive MODIBUFF_JSON....

It's a thing currently with the master branch, should have made a separate branch for it instead, sorry. Will fix that code in the weekend.

[Chillu1]

System.Text.Json is fixed in master branch, haven't touched/looked into the upm/Unity thing yet. But regenerating the meta files/downloading the source manually should work just fine.

[mjfme]

cool! you are right , I add missing .meta files , everything work OK .