ChimeHQ / Chime

An editor for macOS

https://www.chimehq.com

BSD 3-Clause "New" or "Revised" License

314 stars 16 forks source link

Add support to HTML #23

Closed unnamedd closed 1 day ago

unnamedd commented 2 days ago

Description

Add support to HTML

To Do

[x] Find and fix the rendering problem that occurs when an HTML file is opened

Screenshots of the problem

This PR checks one item in the todo list of the issue #20.

mattmassicotte commented 1 day ago

Ok I had a suspicion and it turns out to be correct. NSTextStorage supports a bunch of loading options, and one controls how it interprets known document types. The fix ended up being really easy!

I also removed the addition to the imported UTIs. This is only necessary for UTIs that are not built in. Have to update the documentation.

unnamedd commented 1 day ago

Awesome! Thanks for the research and for removing the extra addition on Info.plist.

unnamedd commented 1 day ago

@mattmassicotte because of your fix, everything seems ok to be moved on. Now the PR is ready for you review/merge.

mattmassicotte commented 1 day ago

Yeah we can revisit the highlighting quality later. That's almost certainly due to poor tree-sitter query definitions.