search

ChimeHQ / Chime

An editor for macOS
https://www.chimehq.com
BSD 3-Clause "New" or "Revised" License
300 stars 14 forks source link

project doesn't build with given README instructions #3

Closed radmakr closed 10 months ago

radmakr commented 10 months ago

I added xcuserdata to gitignore.

For the other changes, please keep in mind that I don't know what I'm doing regarding these .xcconfig files. With that said, I promise my feelings won't be hurt if these changes are completely wrong.

If the bundle ID prefix is set in User.xcconfig then I think the changes I made to these 2 .xcconfig files makes sense? What lead me down this path is that the UIPlaceholder target has the bundle ID hardcoded so the build fails (unless I change it manually). I have no idea how these .xcconfig files are setting the bundle ID so I couldn't update them properly to fix the issue with UIPlaceholder. I figured this PR would just bring the issue to your attention. Also, because of the name, I'm assuming UIPlaceholder isn't sticking around for the long haul, so perhaps all of this is moot.

mattmassicotte commented 10 months ago

First, sorry you ran into trouble. This project is going through a lot of changes. And, because I'm often copy-pasting from the closed-source version, things go wrong sometimes.

I pretty sure what you've done here is correct. You are right that UIPlaceholder is a target used for testing only. But, its bundle id comes from "Extension.xcconfig", and should be fixable in the same matter. I'll have a look at that tomorrow. But in the mean time, this looks great! Thank you so much.

mattmassicotte commented 10 months ago

Fixed up with b1130643396b873463e8872b1117d5ed3ae8dd31!