search

ChimeHQ / Neon

A Swift library for efficient, flexible content-based text styling
BSD 3-Clause "New" or "Revised" License
335 stars 18 forks source link

Fix PaintItBlack PNG reference #6

Closed DivineDominion closed 2 years ago

DivineDominion commented 2 years ago

Closes #5

Of course I saw the file in the root folder after submitting the issue :)

mattmassicotte commented 2 years ago

Thank you so much!

Just looking at this, isn't there a way to make the reference relative? An absolute path seems like the wrong way to do it.

mattmassicotte commented 2 years ago

Indeed there is!

src="PaintItBlack.png?raw=true"

DivineDominion commented 2 years ago

You're right -- I left the fully qualified stuff inside to make cross-fork-references possible, but didn't realize that my fork is of course based off of the current main where the picture exists 😅

WDYT about the ![](...) syntax for the image? Doesn't limit the image width, but tbh I don't know if that was intentional for a more tasteful image viewing experience, or incidental. Can revert to <img> with width limit if you prefer

mattmassicotte commented 2 years ago

To be honest, I think this is an improvement in every way. Thanks so much for doing this!

danielpunkass commented 2 years ago

The explict width on the image was to achieve Retina-quality rendering of the photo. Without it, it displays at twice the size it should. At least in Safari, on my Mac.