Chimeejs / chimee

a video player framework aims to bring wonderful experience on browser
http://chimee.pyzy.net/
MIT License
2.4k stars 202 forks source link

Configuration x5VideoPlayerType should use 'h5-page' instead of 'h5' #355

Closed joe223 closed 4 years ago

joe223 commented 4 years ago

As the code show below:

https://github.com/joe223/chimee/blob/0f04e52355e9ba2316705a0982b134377f3b3729/src/config/video.ts#L246

<video id="video" controls="" preload="" x5-video-player-type="h5" loop="loop" height="150" width="300">
        <source src="http://cdn.tencent.neigou.com/Public/Home/mobileAsset/images/tencent2018/video5.mp4" type="video/mp4">
</video>

That will render X5 video player unexpectedly.

We should set x5-video-player-type to 'h5-page' Due to X5's documentation https://docs.qq.com/doc/DTUxGdWZic0RLR29B

Expected Behavior【期望行为】

Page should render a video as browser-natived.

toxic-johann commented 4 years ago

Can you send me a pull request?

joe223 commented 4 years ago

@toxic-johann Got an error

Cannot find module '../typings/base'

Is there any cmd or script to generate the missing types folder?

toxic-johann commented 4 years ago

Use this branch v0.11.0