search

ChimeraCoder / anaconda

A Go client library for the Twitter 1.1 API
MIT License
1.14k stars 247 forks source link

Fix goroutine leak on error at GetFriendsListAll #186

Closed josephbuchma closed 7 years ago

josephbuchma commented 7 years ago

Close result channel on error to prevent goroutine leak.

birkirb commented 7 years ago

Hey @ChimeraCoder any chance to get this merged? It's a small fix that has significant impact on serious use of the library. Anything else that needs to be done to get this considered?

ChimeraCoder commented 7 years ago

Sorry for the delay. Thanks for the patch!

muesli commented 7 years ago

We should probably propagate the error one way or another.

jaynagpaul commented 6 years ago

Shouldn't this change be added to GetFollowersListAll as well?