Add xrandr to mangohud dependencies

ChimeraOS / chimeraos

A Steam Big Picture based couch gaming OS

MIT License

1.67k stars 116 forks source link

Add xrandr to mangohud dependencies #886

Closed NeroReflex closed 8 months ago

NeroReflex commented 8 months ago

Attempting to build mangohud in a clean chroot with no libxrandr fails as it's missing some needed headers.

Add libxrandr as a dependency.

BoukeHaarsma23 commented 8 months ago

Weird, builds fine here and Mangohud themselves don't have this as far as I can see https://github.com/flightlessmango/MangoHud/blob/master/pkgbuild/PKGBUILD#L9

NeroReflex commented 8 months ago

In file included from ../mangohud/src/app/main.cpp:27: /usr/include/GLFW/glfw3native.h:119:12: fatal error: X11/extensions/Xrandr.h: No such file or directory 119 | #include <X11/extensions/Xrandr.h> | ^~~~~~~~~ compilation terminated.

Now.... If you ask me how that's possible.... I have no idea. I only know including libxrandr fixes it

NeroReflex commented 8 months ago

Doing some digging brought up this: https://gitlab.archlinux.org/archlinux/packaging/packages/glfw/-/blob/15290026dd3dfb55ac4c580d565af021c2202f3a/PKGBUILD

They marked libxrandr in makedepends, I am unsure if this is a runtime dependency (probably is not) so in this case listing it in makedepends would be a better fit?