feat/customWarnMixedMessage

ChimeraTK / ApplicationCore

Core library for creating applications based on the ControlSystemAdapter and DeviceAccess.

GNU Lesser General Public License v3.0

1 stars 2 forks source link

feat/customWarnMixedMessage #365

Closed killenb closed 2 months ago

killenb commented 2 months ago

fix: Missing assignment operator in EventMessageAggregator
chore: increase minor version
feat: custom warn-mixed message in StatusAggregator
fix: coding style

mhier commented 2 months ago

Apparently you did not yet merge the other PR, hence its commits are appearing here again...?

mhier commented 2 months ago

I would prefer if the custom message were settable also through the constructor (with an optional argument). In many cases the owning ModuleGroup of the aggregator might not have a constructor body, so we would have to add one just for setting the message.

killenb commented 2 months ago

Argh, sorry. I did not see that you had requested changes. Already force-pushed the merge with the other PR to the master. The last commit (fixup) has the difference wrt. your last review.