search

ChimeraTK / ControlSystemAdapter

An adapter layer which allows to use control applications with different control system software environments.
GNU Lesser General Public License v3.0
3 stars 2 forks source link

Add Boolean support for the PersistentDataStorage. #41

Closed zenker closed 2 years ago

zenker commented 2 years ago

I left the test almost untouched and just added ChimeraTK::Boolean. One should test all types via templated test case...

zenker commented 2 years ago

Maybe one should increase the minor version rather than the patch version. It's up to @mhier.

killenb commented 2 years ago

Maybe one should increase the minor version rather than the patch version. It's up to @mhier.

Yes, it should be a minor version increase because a feature was added. Servers which use the bool cannot use an older version of the library.

mhier commented 2 years ago

Maybe one should increase the minor version rather than the patch version. It's up to @mhier.

Yes, it should be a minor version increase because a feature was added. Servers which use the bool cannot use an older version of the library.

Well it depends how you view it: In a sense it can be considered a bug that it was forgotten to implement this feature when adding support for the new DeviceAccess version.

Technically it is acceptable to make it a patch release, since no header file was touched (binary compatibility is there). The advantage of a patch version is that you won't need to recompile applications.

So if you prefer you can keep it a patch release from my point of view.

mhier commented 2 years ago

@killenb: If you are ok with a patch release, please merge it.