allow peeking for exceptions in void future_queues

ChimeraTK / cppext

A collection of C++ classes which are quite fundamental and thus considered inside ChimeraTK as an extension of C++.

GNU Lesser General Public License v3.0

2 stars 1 forks source link

allow peeking for exceptions in void future_queues #7

Closed mhier closed 2 years ago

mhier commented 2 years ago

This is needed for the DeviceAccess ReadAnyGroup, to simplify the implementation.

mhier commented 2 years ago

Please increase the minor version number before merging so DeviceAccess can request the required version in CMake.

done.

phako commented 2 years ago

The new code looks fine, but isn't there a return missing in const U& future_queue<T, FEATURES>::front() const ?

mhier commented 2 years ago

The new code looks fine, but isn't there a return missing in const U& future_queue<T, FEATURES>::front() const ?

err, you are right. there seems to be a test missing for the const case, so the code is not even instantiated and hence we don't get any warnings... I will make a separate pull request for this.