Resolve symlinks during build generation

ChimeraTK / project-template

Template for new projects. Can also be used to update cmake scripts in existing projects by merging the changes. This repository intentionally does not have a README.md (which would create conflicts in the projects using this template). For documentation, please follow this link:

https://github.com/ChimeraTK/project-template/blob/master/HowTo_project-template.md

GNU Lesser General Public License v3.0

1 stars 3 forks source link

Resolve symlinks during build generation #42

Closed Amadrath closed 9 months ago

Amadrath commented 9 months ago

Changes, how links are treated during build generation:

non-absolute paths are resolved
symlink is replaced by target file, renamed to the symlinks filename

This is required to use symlinks to point to shared resources outside of the project directory, because otherwise the symlink file is copied as-is, resulting in a broken symlink.

The ability to link to files in the same directory (i.e. chain-linking) is preserved by using a temporary directory to copy the files to, before renaming/moving them.

The functionality has been tested with an EPICS llrfctrl configuration.

mhier commented 9 months ago

First a formal comment: Commits message in the project-template must follow strictly the conventional commits, see https://www.conventionalcommits.org (other projects should follow that as well), otherwise we cannot distribute this change to the projects. Please change the commit message accordingly!

mhier commented 9 months ago

Can you elaborate at an example why this is necessary? I don't fully understand the problem which you are trying to solve here...

mhier commented 9 months ago

First a formal comment: Commits message in the project-template must follow strictly the conventional commits, see https://www.conventionalcommits.org (other projects should follow that as well), otherwise we cannot distribute this change to the projects. Please change the commit message accordingly!

One more comment about commit naming: please keep in mind that the project-template is used as a basis for all our projects, not only config packages. It should be evident from the commit message that this change is related to config packages, e.g. by using "(conf-gen)" as a scope (right after the initial type keyword like "feat" or "fix").