Closed Amadrath closed 9 months ago
Why did you open a new PR for this? You could have simply pushed into the same branch... (btw: please also avoid force-pushing during reviews, it makes it hard to understand which are new changes and which have been reviewed already)
In any case, the code looks now a lot cleaner, but I still don't understand what problem should be solved with it. Can you please give me an example where you want to use symlinks and why they must be converted into hard copies during installation?
I made a new branch, because this is not a change of the former branch (resolve_link) but a completely different change, based on the master branch, which also is not compatible to the changes in the resolve_link branch.
I want to add llrfctrl-config as a submodule to my external llrfctrl-config repos, to link files like 000-makeBaseConfig.py from the base repo to the external ones. This way, all I have to do, to make sure I have the correct files in my config, is to checkout the corresponding tag in the submodule. This way I don't have to maintain a list of files to copy in the CMakeLists.txt. It also helps, to see the file in the filesystem to understand references in the other files during development.
Ah so the point is that the link points to a git submodule which is not installed of course. All right, thanks.
Please wait with the merge, there is some delicate merge operation in progress by @killenb - @killenb can you merge this once you are done?
Yes, I will take care of it once I am through with my task.
sorry, my mistake, I gave Patrick the wrong instructions... fixed!
Instead of copying a symlink file, resulting in a broken link, the target file is copied instead, unless the target is in the same directory, in which case the symlink is maintained.