Closed adarsh-jha-dev closed 4 weeks ago
Hey @phyleria , could you please review this whenever you're free.
@phyleria , any update on this?
hey @phyleria , tomorrow is the merging day of the week, so is there any update on this? (Sorry If i am being too impatient)
Np , I have pushed the changes as requested by you, please review them whenever you're free. Thank you.
Hey @phyleria , any update on this?
Hi @adarsh-jha-dev
I noticed that you used AI for the article (not a bad thing) and there are quite a few corrections needed to make it reader-friendly and cohesive. I'll take some time to compile all the feedback into a clear and comprehensive format, so it's easier for you to make the necessary changes. Thanks for following up
Hi @adarsh-jha-dev
I noticed that you used AI for the article (not a bad thing) and there are quite a few corrections needed to make it reader-friendly and cohesive. I'll take some time to compile all the feedback into a clear and comprehensive format, so it's easier for you to make the necessary changes. Thanks for following up
Yeah, I often take help from it, thanks for the feedback. I'll wait.
I believe with this changes, the article will be good to go. Thanks @adarsh-jha-dev !
I believe with this changes, the article will be good to go. Thanks @adarsh-jha-dev !
cool, Thanks @phyleria.
I believe with this changes, the article will be good to go. Thanks @adarsh-jha-dev !
so you mean no more changes right? I hope you reviewed the latest one.
Yeah, I reviewed the latest one. Incase there are any more changes on the one you submit after the changes I will let you know but for now no.
Almost ready for merging @adarsh-jha-dev ! You’ve done a great job, and just a few minor adjustments:
- Some sections mention “Reference” and “Chimoney API Docs,” but the actual links are missing. Could you kindly link them?
Example:
Visit the [Chimoney API Documentation](https://docs.chimoney.io).
- A few sections come off as slightly formal (e.g., “vital to marketplace success”). A more conversational tone can help better engage the readers.
Example:
- Instead of: "Payouts are vital to marketplace success."
- Try: "Seamless payouts help keep your users happy and engaged."
- Can you please include a simple code sample demonstrating a payout request using Chimoney’s API? You can check out an example of how it was done in this blog
That will be all. Sorry for the late review
wait,I am a little confused, I have already pushed these changes , I hope you're satisfied with the changes and let me know if anything more is to be done from my end. Thank you!
Hi @adarsh-jha-dev
Please check the comment time/day. That was four days ago and you resolved that.
The changes I have requested are from two hours ago
Hi @adarsh-jha-dev
Please check the comment time/day. That was four days ago and you resolved that.
The changes I have requested are from two hours ago
Exactly, where are the new changes that you requested? I only see that you changed the PR title, what other changes are you talking about? Sorry If I am missing something.
Oh, I reviewed from codespaces and seems like it didn't reflect on your end, though I can see from my end. Let me resolve that
Are you able to see the comments now @adarsh-jha-dev?
Are you able to see the comments now @adarsh-jha-dev?
yes, thanks for resolving, working on them, will be pushing any moment.
Thanks @phyleria , could you please put the hacktoberfest-accepted
tag here?
Done ✅
Done ✅
Thanks a lot.
@phyleria, PR merged. Please send a chimoney.io reward to @adarsh-jha-dev
closes #383