search

Chingu-cohorts / devgaido

Chingu Learning Path application
https://devgaido.com
MIT License
25 stars 3 forks source link

Wrong width value for the logo image inside the Auth0LockWidget component #124

Closed willamesoares closed 7 years ago

willamesoares commented 7 years ago

I noticed the value set for the width attribute in the auth0-lock-header-logo class is allowing it to spawn beyond the wrapper boundaries, as shown in the image below.

logo-before

By setting the width to 100% the logo lies entirely inside the wrapper block, as shown below.

logo-after

I checked the file style.styl and noticed that the value suggested to this class width is already being set. However, in production, it seems that this value is not being applied.

.auth0-lock-header-logo
  width 100% !important
jdmedlock commented 7 years ago

Thanks @willamesoares! We'll look into this and will include a fix in the next release

jdmedlock commented 7 years ago

Issue is suspected to be due to classes in the Auth0 component not being whitelisted so they are skipped by CSS Purify, which prunes unneeded CSS elements from the bundle. Research and corrective action is underway.

jdmedlock commented 7 years ago

Resolved by whitelisting Auth0 CSS classes in webpack.config.js that we've overridden in devGaido. Will be promoted to Production at next release.