search

Chingu-cohorts / devgaido

Chingu Learning Path application
https://devgaido.com
MIT License
25 stars 3 forks source link

Login, and stay on the page that you were on. #146

Open thatrobotdev opened 7 years ago

thatrobotdev commented 7 years ago

When I use devGaido, I have two bookmarks in my browser which go to the Frontend course, and the Fullstack course. Here are the steps to my login:

  1. Click Bookmark
  2. Click Login Button, and log in with my GitHub
  3. Get Redirected to Dashboard
  4. Click Bookmark again to get back to the course I wanted to look at

Instead, I was wondering if this is what could happen:

  1. Click Bookmark
  2. Click Login Button, and log in with my GitHub
  3. Browse the course I want to look at

I don't see a reason to redirect to the dashboard every time I log in since I use devGaido constantly to update my progress and don't like clicking my bookmark 2 times to get to one place.

jdmedlock commented 7 years ago

The original use case was that following Login the user would want to see overall progress before jumping to a particular bookmark. However, we'll look into this to see what is involved to honor bookmarks following a Login.

thatrobotdev commented 7 years ago

Thank you @jdmedlock!

jdmedlock commented 7 years ago

This issue stems from the fact that we are using Auth0 for authentication and are experiencing some difficulties in persisting the bookmarked URL so its available after the return from Auth0. We are looking into this without opening any security holes (cookies are not the answer), but it will likely take some time and experimentation. We are leaving this issue open until we have identified and implemented a solution.