search

Chinmayamission / CFF

Chinmaya Forms Framework
http://docs.chinmayamission.com/cff/
Apache License 2.0
12 stars 10 forks source link

[MSC] Paypal with installment gives an error #137

Closed epicfaace closed 5 years ago

epicfaace commented 5 years ago

Reported by @paragbhatt on slack (please make a github issue in the future)

image

Steps:

  1. Go to https://forms.chinmayamission.com/v2/forms/5c96811ed0443d00011255d5?responseId=5d363e420d053400019031d5
  2. Click "Submit" and then "pay now"
  3. Click on "Paypal check out" to sign in to subscribe.
  4. You will see the error screen.
epicfaace commented 5 years ago

The issue was that formOptions had:

  "paymentMethods": {
    "paypal_classic": {
      "zip": "$address.zip",

Changed the above to 

  "paymentMethods": {
    "paypal_classic": {
      "zip": "$address.zipcode",

Because there is no field called zip, only a field called zipcode. Thus, previously it was setting zip to "."

Should we look into not making "." the default value for undefined fields, or maybe instead, just having validation on paypal fields before it's sent to PayPal?

paragbhatt commented 5 years ago

Will it work for international PayPal payees?

epicfaace commented 5 years ago

Not sure, it probably should as long as they pay in USD.