gt9xx on 6.4.16-v8+

[nicoske]

Hi,

I'm testing kernel 6.4.16-v8+ and I can't compile gt9xx

make -C /lib/modules/6.4.16-v8+/build M=`pwd` modules
make[1]: Entering directory '/home/nico/rpi-6.4.y'
  CC [M]  /home/nico/industrial-pi/gt9xx/gt9xx_update.o
In file included from ./include/asm-generic/bug.h:22,
                 from ./arch/arm64/include/asm/bug.h:26,
                 from ./include/linux/bug.h:5,
                 from ./arch/arm64/include/asm/cpufeature.h:20,
                 from ./arch/arm64/include/asm/ptrace.h:11,
                 from ./arch/arm64/include/asm/irqflags.h:10,
                 from ./include/linux/irqflags.h:16,
                 from ./include/linux/rcupdate.h:26,
                 from ./include/linux/rculist.h:11,
                 from ./include/linux/pid.h:5,
                 from ./include/linux/sched.h:14,
                 from ./include/linux/kthread.h:6,
                 from /home/nico/industrial-pi/gt9xx/gt9xx_update.c:21:
/home/nico/industrial-pi/gt9xx/gt9xx_update.c: In function ‘gup_check_update_file’:
/home/nico/industrial-pi/gt9xx/gt9xx.h:352:49: error: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘__kernel_size_t’ {aka ‘long unsigned int’} [-Werror=format=]
  352 |                                          printk("<<-GTP-DEBUG->> [%d]"fmt"\n",__LINE__, ##arg);\
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/printk.h:427:11: note: in definition of macro ‘printk_index_wrap’
  427 |   _p_func(_fmt, ##__VA_ARGS__);    \
      |           ^~~~
/home/nico/industrial-pi/gt9xx/gt9xx.h:352:42: note: in expansion of macro ‘printk’
  352 |                                          printk("<<-GTP-DEBUG->> [%d]"fmt"\n",__LINE__, ##arg);\
      |                                          ^~~~~~
/home/nico/industrial-pi/gt9xx/gt9xx_update.c:884:9: note: in expansion of macro ‘GTP_DEBUG’
  884 |         GTP_DEBUG("Update File path:%s, %d", path, strlen(path));
      |         ^~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:252: /home/nico/industrial-pi/gt9xx/gt9xx_update.o] Error 1
make[1]: *** [Makefile:2032: /home/nico/industrial-pi/gt9xx] Error 2
make[1]: Leaving directory '/home/nico/rpi-6.4.y'
make: *** [Makefile:21: compile] Error 2

[nicoske]

Seems not necessary anymore since module is available in kernel mainline and device tree overlay is provided by raspberry pi. dtoverlay=goodix,interrupt=7,reset=8

[Liu-Xiaoqiang]

Yes, you are right, we can use dtoverlay=goodix in future, it's one good solution.